fix: log an error when inbound fails #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when `inbound()` fails, nothing is logged, and you don't see what went wrong
ljedrz
reviewed
Jun 7, 2024
| @@ -117,6 +117,7 @@ impl<N: Network, C: ConsensusStorage<N>> Reading for Client<N, C> { | |||
| async fn process_message(&self, peer_addr: SocketAddr, message: Self::Message) -> io::Result<()> { | |||
| // Process the message. Disconnect if the peer violated the protocol. | |||
| if let Err(error) = self.inbound(peer_addr, message).await { | |||
| error!("Failed to process inbound message from '{peer_addr}' - {error}"); | |||
There was a problem hiding this comment.
This log would be almost the same as the one displayed if the peer is still connected; I'm in favor of reporting the error regardless, but I think we may want to either remove the preexisting WARN or to change its message to no longer state the error (instead it could state sth like Disconnecting from '{peer_ip}' for protocol violation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
self.inbound()fails, sometimes, nothing is logged, and you don't see that anything went wrong.This tripped me up when diagnosing sync issues.