-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom task run name rendering #15773
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fa51da7
wip
zzstoatzz 0b465ba
try alternate path
zzstoatzz b078e9c
fix typing and update test
zzstoatzz 6fd350d
order should not matter
zzstoatzz d14cd6e
add templating sytnax example
zzstoatzz 08bf7d2
more precise typing
zzstoatzz 32348bb
revert bad git state
zzstoatzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
"""This is a regression test for https://github.com/PrefectHQ/prefect/issues/15747""" | ||
|
||
from typing import Any | ||
|
||
from prefect import flow, task | ||
from prefect.context import TaskRunContext | ||
from prefect.runtime import task_run | ||
|
||
names = [] | ||
|
||
|
||
def generate_task_run_name(parameters: dict) -> str: | ||
names.append(f'{task_run.task_name} - input: {parameters["input"]["number"]}') | ||
return names[-1] | ||
|
||
|
||
def alternate_task_run_name() -> str: | ||
names.append("wildcard!") | ||
return names[-1] | ||
|
||
|
||
@task(task_run_name="other {input[number]}") | ||
def other_task(input: dict) -> dict: | ||
names.append(TaskRunContext.get().task_run.name) | ||
return input | ||
|
||
|
||
@task(log_prints=True, task_run_name=generate_task_run_name) | ||
def increment_number(input: dict) -> dict: | ||
input["number"] += 1 | ||
return input | ||
|
||
|
||
@flow | ||
def double_increment_flow() -> list[dict[str, Any]]: | ||
inputs = [ | ||
{"number": 1, "is_even": False}, | ||
{"number": 2, "is_even": True}, | ||
] | ||
|
||
first_increment = increment_number.map(input=inputs) | ||
second_increment = increment_number.with_options( | ||
task_run_name=alternate_task_run_name | ||
).map(input=first_increment) | ||
final_results = second_increment.result() | ||
|
||
other_task.map(inputs).wait() | ||
|
||
print(f"Final results: {final_results}") | ||
return final_results | ||
|
||
|
||
async def test_flow_with_mapped_tasks(): | ||
results = double_increment_flow() | ||
assert results == [ | ||
{"number": 3, "is_even": False}, | ||
{"number": 4, "is_even": True}, | ||
] | ||
assert set(names) == { | ||
"increment_number - input: 1", | ||
"increment_number - input: 2", | ||
"wildcard!", | ||
"wildcard!", | ||
"other 3", | ||
"other 4", | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we pass the parameters if the author of the callable requests
parameters