Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve parameters sooner #15770

Closed
wants to merge 2 commits into from
Closed

Resolve parameters sooner #15770

wants to merge 2 commits into from

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Oct 21, 2024

closes #15747

we couldn't really defer the custom naming of the task run, because we need to associate the rendered name with the run so that it properly appears in logs / API, so we have to instead resolve parameters sooner

@github-actions github-actions bot added the bug Something isn't working label Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #15770 will not alter performance

Comparing resolve-parameters-sooner (61830e1) with main (4583539)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz closed this Oct 22, 2024
@zzstoatzz
Copy link
Collaborator Author

superseded by #15773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callabe task name generators (3.0 vs. 2.x)
1 participant