Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid raising errors on database passwords that contain a $ character #14888

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Avoid raising errors on database passwords that contain a $ character #14888

merged 1 commit into from
Aug 12, 2024

Conversation

desertaxle
Copy link
Member

This PR fixes errors raised when a database password contains a $ character by using safe_substitute when templating.

Port of #14876 to the 2.x line.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@desertaxle desertaxle requested a review from a team as a code owner August 12, 2024 13:33
@desertaxle desertaxle merged commit 6b7ccd2 into 2.x Aug 12, 2024
59 checks passed
@desertaxle desertaxle deleted the fix-dbconnection-string-templating-2.x branch August 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@zzstoatzz zzstoatzz zzstoatzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desertaxle @chrisguidry @zzstoatzz