-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates for event and metric triggers #12366
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❤️ ❤️ ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woot! this is so exciting
docs/concepts/automations.md
Outdated
@@ -47,7 +47,7 @@ On the **Automations** page, select the **+** icon to create a new automation. Y | |||
|
|||
### Triggers | |||
|
|||
Triggers specify the conditions under which your action should be performed. Triggers can be of several types, including triggers based on: | |||
Triggers specify the conditions under which your action should be performed. The Prefect UI includes templates for many common situations, like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Triggers specify the conditions under which your action should be performed. The Prefect UI includes templates for many common situations, like: | |
Triggers specify the conditions under which your action should be performed. The Prefect UI includes templates for many common situations, such as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing a few minor edits for clarity.
I think we should avoid the word "stream" because of some of the connotations it carries. It we need a word, I'm more comfortable with "event feed", but in most cases I think we can get a away with just "events."
As part of our expansion of triggers to new use cases, I wanted to refresh the documentation for triggers to make room for docs about metric and composite triggers. Co-authored-by: nate nowack <thrast36@gmail.com> Co-authored-by: Bill Palombi <bill@prefect.io>
9545241
to
bb77b2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Minor nits.
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: nate nowack <thrast36@gmail.com> Co-authored-by: Bill Palombi <bill@prefect.io> Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
As part of our expansion of triggers to new use cases, I wanted to refresh the
documentation for triggers to make room for docs about metric and composite
triggers.