District Child Tax Credit #5262
Draft
+266
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PolicyEngine#5183 Co-authored-by: Pinyan <pxu12@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5262 +/- ##
========================================
Coverage 99.12% 99.13%
========================================
Files 2592 2608 +16
Lines 37707 37916 +209
Branches 162 161 -1
========================================
+ Hits 37378 37588 +210
+ Misses 297 296 -1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Oct 23, 2024
policyengine_us/parameters/gov/states/dc/tax/income/credits/ctc/child/age_threshold.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ctc/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ctc/child/child_cap.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ctc/child/child_cap.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/dc/tax/income/credits/ctc/phase_out/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/dc/tax/income/credits/ctc/dc_ctc.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/dc/tax/income/credits/ctc/dc_ctc.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/dc/tax/income/credits/ctc/dc_ctc.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/dc/tax/income/credits/ctc/dc_ctc.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
could you add it to the refundable credits in DC
There was a problem hiding this comment.
Add it to the refundable credits list would cause errors in the "conrtib" folder.
|
Could you delete the dc ctc from the reform structure? We can just delete anything that was added in this PR - |
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue5183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5183
Co-authored-by: Pinyan pxu12@users.noreply.github.com