-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new structure for Indiana dependent exemptions #5224
base: master
Are you sure you want to change the base?
Create new structure for Indiana dependent exemptions #5224
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5224 +/- ##
=======================================
Coverage 99.12% 99.13%
=======================================
Files 2592 2599 +7
Lines 37707 37778 +71
Branches 162 160 -2
=======================================
+ Hits 37378 37450 +72
+ Misses 297 296 -1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
- Modified in_base_exemptions.py to separate out dependents and spouse/head. | ||
- Modified tests in in_base_exemptions.yaml. | ||
added: | ||
- Added more tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Modified in_base_exemptions.py to separate out dependents and spouse/head. | |
- Modified tests in in_base_exemptions.yaml. | |
added: | |
- Added more tests. | |
- Separate Indiana dependent exemptions. |
@@ -9,6 +9,7 @@ metadata: | |||
reference: | |||
- title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | |||
href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 | |||
- title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also an href (hyperlink)
@@ -9,6 +9,7 @@ metadata: | |||
reference: | |||
- title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | |||
href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 | |||
- title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont need the same reference multiple times
metadata: | ||
period: year | ||
unit: currency-USD | ||
label: Indiana exemptions base amount - dependent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label: Indiana exemptions base amount - dependent | |
label: Indiana dependent exemptions amount |
reference: | ||
- title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | ||
href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 | ||
- title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
label: Indiana exemptions base amount - dependent | ||
reference: | ||
- title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | ||
href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you double check that all references show the number
@@ -0,0 +1,16 @@ | |||
description: Indiana provides this base exemption amount for dependent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Indiana provides this base exemption amount for dependent. | |
description: Indiana provides this base exemption amount for each dependent. |
tax_unit_dependents: 0 | ||
state_code: IN | ||
output: | ||
ga_exemptions: 2_000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to test in_base_exemptions
period: 2021 | ||
input: | ||
filing_status: JOINT | ||
tax_unit_dependents: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you create also some tests with available dependents
|
||
dependent_exemptions = dependents * p.base.dependent | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete white space
To run the test:
|
Fixes #5223