Create new structure for Indiana dependent exemptions #5224
+64
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5224 +/- ##
=======================================
Coverage 99.12% 99.13%
=======================================
Files 2592 2599 +7
Lines 37707 37778 +71
Branches 162 160 -2
=======================================
+ Hits 37378 37450 +72
+ Misses 297 296 -1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Oct 25, 2024
Comment on lines
+4
to
+7
| - Modified in_base_exemptions.py to separate out dependents and spouse/head. | ||
| - Modified tests in in_base_exemptions.yaml. | ||
| added: | ||
| - Added more tests. |
There was a problem hiding this comment.
Suggested change
| - Modified in_base_exemptions.py to separate out dependents and spouse/head. | |
| - Modified tests in in_base_exemptions.yaml. | |
| added: | |
| - Added more tests. | |
| - Separate Indiana dependent exemptions. |
| @@ -9,6 +9,7 @@ metadata: | |||
| reference: | |||
| - title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | |||
| href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 | |||
| - title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 | |||
There was a problem hiding this comment.
also an href (hyperlink)
| @@ -9,6 +9,7 @@ metadata: | |||
| reference: | |||
| - title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | |||
| href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 | |||
| - title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 | |||
There was a problem hiding this comment.
Suggested change
| - title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
There was a problem hiding this comment.
Dont need the same reference multiple times
| metadata: | ||
| period: year | ||
| unit: currency-USD | ||
| label: Indiana exemptions base amount - dependent |
There was a problem hiding this comment.
Suggested change
| label: Indiana exemptions base amount - dependent | |
| label: Indiana dependent exemptions amount |
| reference: | ||
| - title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | ||
| href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 | ||
| - title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
There was a problem hiding this comment.
Suggested change
| - title: 2023 IT-40 Income Tax Form Instruction Booklet, pg. 30 |
| label: Indiana exemptions base amount - dependent | ||
| reference: | ||
| - title: IC 6-3-1-3.5 "Adjusted gross income" (a)(3)-(4) | ||
| href: http://iga.in.gov/legislative/laws/2021/ic/titles/006#6-3-1-3.5 |
There was a problem hiding this comment.
could you double check that all references show the number
| @@ -0,0 +1,16 @@ | |||
| description: Indiana provides this base exemption amount for dependent. | |||
There was a problem hiding this comment.
Suggested change
| description: Indiana provides this base exemption amount for dependent. | |
| description: Indiana provides this base exemption amount for each dependent. |
| tax_unit_dependents: 0 | ||
| state_code: IN | ||
| output: | ||
| ga_exemptions: 2_000 |
There was a problem hiding this comment.
need to test in_base_exemptions
| period: 2021 | ||
| input: | ||
| filing_status: JOINT | ||
| tax_unit_dependents: 0 |
There was a problem hiding this comment.
could you create also some tests with available dependents
|
|
||
| dependent_exemptions = dependents * p.base.dependent | ||
|
|
||
|
|
There was a problem hiding this comment.
delete white space
|
To run the test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5223