Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply five-year-forward check on all reforms #5136

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

leehengpan
Copy link
Collaborator

Fix #4912

@PavelMakarchuk
Copy link
Collaborator

Great @leehengpan - can you add an entry changelog_entry.yaml and run make format as well as an git pull upstream master

last thing are test adjustments - please take a look at the dc_kccatc

@PavelMakarchuk PavelMakarchuk marked this pull request as draft September 25, 2024 23:30
@leehengpan
Copy link
Collaborator Author

Great @leehengpan - can you add an entry changelog_entry.yaml and run make format as well as an git pull upstream master

last thing are test adjustments - please take a look at the dc_kccatc

I have added changelog_entry and run all the above commands. Let me know if anything needs modifying. Thanks.

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make this a utility to reduce code duplication?

@PavelMakarchuk
Copy link
Collaborator

Could you please make this a utility to reduce code duplication?

Lets file a new issue to consolidate into a utility ad get this merged once tests pass @leehengpan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply the five-year-forward check for all reforms
3 participants