Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy to >=1.24.2,1.25 #103

Closed
wants to merge 1 commit into from

Conversation

MaxGhenis
Copy link
Contributor

Fixes #101

Thanks for contributing! Please remove any top-level sections that do not apply to your changes.

  • make format && make documentation has been run.

New variable

  • Label field added
  • Documentation field added
  • Unit field added
  • Default value field added if relevant
  • Variable name follows conventions
  • Unit test(s) added
  • Integration test(s) added if relevant
  • Issues this PR fixes linked

What's changed

Description of the changes here.

Bug fix

  • Regression test added
  • Regression test passing

What this fixes and how it's fixed

Description of how this fix works goes here. Link any issues this PR fixes.

@MaxGhenis MaxGhenis changed the title Update numpy to >=0.24.2 Update numpy to >=1.24.2,1.25 Jun 26, 2023
@nikhilwoodruff
Copy link
Contributor

OK the issue seems to be primarily around how OpenFisca uses numpy dtypes for Enum values

@martinholmer
Copy link

@nikhilwoodruff said in PR #103:

OK the issue seems to be primarily around how OpenFisca uses numpy dtypes for Enum values

I'm puzzled by this observation.
If true, then how has OpenFisca upgraded to numpy 1.24?

From .conda/meta.yaml:

- numpy >=1.24.2,<1.25.0

@MaxGhenis
Copy link
Contributor Author

Superseded by #117

@MaxGhenis MaxGhenis closed this Oct 2, 2023
@MaxGhenis MaxGhenis deleted the MaxGhenis/issue101 branch October 2, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update numpy to >=0.24.2
3 participants