Fix random issue (#138)

* Fix randomness issue by forcing seed resets * Changelog
PolicyEngine · Dec 21, 2023 · c234fde · c234fde
1 parent f3fae34
commit c234fde
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+    - Randomness issue.
diff --git a/policyengine_core/commons/formulas.py b/policyengine_core/commons/formulas.py
@@ -300,14 +300,14 @@ def amount_between(
     return clip(amount, threshold_1, threshold_2) - threshold_1
 
 
-def random(entity, reset=False):
-    if entity.simulation.has_axes:
-        # Generate the same random number for each entity.
-        random_number = np.random.rand(1)[0]
-        return np.array([random_number] * entity.count)
+def random(entity, reset=True):
     if reset:
         np.random.seed(0)
     x = np.random.rand(entity.count)
+    if entity.simulation.has_axes:
+        # Generate the same random number for each entity.
+        random_number = x[0]
+        return np.array([random_number] * entity.count)
     return x