Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe button on homepage #601

Closed
wants to merge 4 commits into from
Closed

Subscribe button on homepage #601

wants to merge 4 commits into from

Conversation

sohaibaumer
Copy link

@sohaibaumer sohaibaumer commented Jul 6, 2023

Fixes #598

  • Renamed the branch/commit as per requirement.

  • Screenshot is also attached:
    Fixes-#598 Subscribe button on homepage

@MaxGhenis
Copy link
Contributor

MaxGhenis commented Jul 6, 2023

Thanks - looks nice. Could you please:

  • Zoom out for the screenshot so we can see where the content below is
  • Add a mobile screenshot
  • Remove Fixes #598 from the PR title and move it into the PR description (the first comment, which you can edit). You'll know you've correctly linked it when it shows up in the Development section on the right sidebar

@sohaibaumer sohaibaumer changed the title Fixes #598 Subscribe button on homepage Subscribe button on homepage Jul 6, 2023
@sohaibaumer
Copy link
Author

Fixes #598

Desktop Screenshot:
Fixes-#598 Desktop

Mobile Screenshot:
Fixes-#598 Mobile

Copy link
Contributor

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sohaibaumer - looks great. I made a few style changes (fixing centering and removing the top white gap). I couldn't immediately figure out the test issue though, do you have any ideas what changed?

@sohaibaumer
Copy link
Author

@nikhilwoodruff
not sure, I re-ran the test and they pass.
image
PS, I didn't change much in code anyways, re-used one of your existing functions.

@MaxGhenis
Copy link
Contributor

Any update here? Could you try pulling in the latest changes to see if that affects CI?

@MaxGhenis
Copy link
Contributor

What's the status on this?

@anth-volk
Copy link
Collaborator

anth-volk commented Dec 11, 2023 via email

@anth-volk
Copy link
Collaborator

Closing, as this functionality was added with #924.

@anth-volk anth-volk closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Subscribe button on homepage
4 participants