-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe button on homepage #601
Subscribe button on homepage #601
Conversation
Thanks - looks nice. Could you please:
|
Fixes #598 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sohaibaumer - looks great. I made a few style changes (fixing centering and removing the top white gap). I couldn't immediately figure out the test issue though, do you have any ideas what changed?
@nikhilwoodruff |
Any update here? Could you try pulling in the latest changes to see if that affects CI? |
…hub.com/sohaibaumer/policyengine-app into Fixes-#598-Subscribe-button-on-homepage
What's the status on this? |
I wrote a PR last week that creates this functionality, but it could probably be made more robust with front-end authentication practices in the future. I believe Nikhil has pushed the code into prod.
… On Dec 10, 2023, at 11:18, Max Ghenis ***@***.***> wrote:
What's the status on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
Closing, as this functionality was added with #924. |
Fixes #598
Renamed the branch/commit as per requirement.
Screenshot is also attached: