-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate Breadcrumbs #2023
Reinstate Breadcrumbs #2023
Conversation
Reinstates logic for clicking breadcrumbs in mobile as navigation. Adds logic to address clicking breadcrumb for Policy Output to mirror that of Household Impact.
Everything seems to work, still need to test thoroughly and remove console.logs
@rachel-lawrie I believe you said this is ready for review, but if so, would you mind moving it out of draft? |
@rachel-lawrie I suspect the test failure was a fluke, as other PRs failed similarly around the same time as yours, except these were incredibly minor. They've also all been re-run and passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @rachel-lawrie. Just had a couple code quality requests, then this should be good to merge!
src/pages/PolicyPage.jsx
Outdated
middle = ( | ||
<> | ||
// eslint-disable-next-line no-console | ||
console.log("focus:" + focus); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this and the below console statements?
src/pages/PolicyPage.jsx
Outdated
} | ||
|
||
// This code works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unclear as to what this commented code block is for
src/pages/PolicyPage.jsx
Outdated
); | ||
} else { | ||
// eslint-disable-next-line no-console | ||
console.log("no node"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this console log, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @rachel-lawrie!
Reinstates logic for clicking breadcrumbs in mobile to serve as navigation.
Note that clicking breadcrumbs were disabled as part of #1947.
Description
Fixes #2022
Screenshots
https://www.loom.com/share/79ab325e6fa0402eb70b7bef0cff72f8?sid=cff59996-d6e2-40ad-a00e-a5e8b0c36868
Tests
Tested locally (created new policy, clicked through each policy, compared to tree to ensure no pages are missing).
Also ran test suite. 8 are failing but not due to any of these changes. I compared to the master branch and all 8 were failing there too.