Reinstate Breadcrumbs #2023
Merged
Reinstate Breadcrumbs #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinstates logic for clicking breadcrumbs in mobile as navigation. Adds logic to address clicking breadcrumb for Policy Output to mirror that of Household Impact.
Everything seems to work, still need to test thoroughly and remove console.logs
|
@rachel-lawrie I believe you said this is ready for review, but if so, would you mind moving it out of draft? |
|
@rachel-lawrie I suspect the test failure was a fluke, as other PRs failed similarly around the same time as yours, except these were incredibly minor. They've also all been re-run and passed. |
anth-volk
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Thanks for this, @rachel-lawrie. Just had a couple code quality requests, then this should be good to merge!
src/pages/PolicyPage.jsx
Outdated
| middle = ( | ||
| <> | ||
| // eslint-disable-next-line no-console | ||
| console.log("focus:" + focus); |
There was a problem hiding this comment.
Could you remove this and the below console statements?
src/pages/PolicyPage.jsx
Outdated
| } | ||
|
|
||
| // This code works |
There was a problem hiding this comment.
I'm a bit unclear as to what this commented code block is for
src/pages/PolicyPage.jsx
Outdated
| ); | ||
| } else { | ||
| // eslint-disable-next-line no-console | ||
| console.log("no node"); |
There was a problem hiding this comment.
Could you remove this console log, as well?
anth-volk
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstates logic for clicking breadcrumbs in mobile to serve as navigation.
Note that clicking breadcrumbs were disabled as part of #1947.
Description
Fixes #2022
Screenshots
https://www.loom.com/share/79ab325e6fa0402eb70b7bef0cff72f8?sid=cff59996-d6e2-40ad-a00e-a5e8b0c36868
Tests
Tested locally (created new policy, clicked through each policy, compared to tree to ensure no pages are missing).
Also ran test suite. 8 are failing but not due to any of these changes. I compared to the master branch and all 8 were failing there too.