Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary PCL_EXPORTS in common #6141

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Sep 26, 2024

When:

  • a method was templated
  • the full definition was present in the header

Except for any range_image files.

See #5779 for reference.

@larshg larshg added module: common changelog: fix Meta-information for changelog generation labels Sep 26, 2024
@larshg larshg changed the title Remove unnecessary PCL_EXPORTS Remove unnecessary PCL_EXPORTS in common Sep 26, 2024
* a method was templated
* the full definition was present in the header
@larshg larshg force-pushed the RemoveWrongPCLEXPORTSCommon branch from 3975066 to de4c0e9 Compare October 3, 2024 18:05
@larshg larshg requested a review from mvieth October 19, 2024 19:03
@larshg larshg merged commit a631b72 into PointCloudLibrary:master Oct 23, 2024
13 checks passed
@larshg larshg deleted the RemoveWrongPCLEXPORTSCommon branch October 23, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants