Rewriting constants #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing path typo in rust-lite
rust-lite/src/rust_lite/__main__.py
Outdated
| @@ -60,7 +60,7 @@ def exec_run(options: RunOptions) -> None: | |||
| print('Performed all possible rewriting operations; Trying to fetch the content of the K cell.') | |||
|
|
|||
| module_manager.print_k_top_element() | |||
|
|
|||
There was a problem hiding this comment.
Empty space change, it may be worth removing.
tests/execution/constant-lookup.rs
Outdated
| fn lookup_constant(&self) -> u64 { YEARLY_INTEREST } | ||
|
|
||
| fn lookup_constant_with_type(&self) -> u64 { | ||
| let x = YEARLY_INTEREST::u64; |
There was a problem hiding this comment.
Does this actually work if you try to compile it with rustc? Shouldn't this be let x = YEARLY_INTEREST;?
tests/execution/constant-lookup.rs
Outdated
|
|
||
| fn lookup_constant_with_type(&self) -> u64 { | ||
| let x = YEARLY_INTEREST::u64; | ||
| x } |
virgil-serbanuta
approved these changes
Sep 4, 2024
| @@ -24,5 +24,10 @@ module RUST-CONSTANTS | |||
| </constant> | |||
| ... | |||
| </constants> | |||
|
|
|||
There was a problem hiding this comment.
This rule should actually be in a new file, called rust-semantics/expression/constants.mx. This file (and its module) should be required/imported in the same places as rust-semantics/expression/literals.md, so that it will be used both for preprocessing and for execution.
… it for both preprocessing and execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing constant lookup at preprocessing time.