Mx blockchain hooks #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgil-serbanuta
force-pushed
the
mx-blockchain
branch
from
f842671
to
c208237
Compare
ACassimiro
reviewed
Aug 29, 2024
| configuration | ||
| <mx-blocks> | ||
| <mx-current-block> | ||
| <mx-current-block-timestamp> 0 </mx-current-block-timestamp> |
There was a problem hiding this comment.
Right now my understanding is that our timing information is arbitrary, as we do not compute time at the moment, correct?
There was a problem hiding this comment.
Yes, that's correct. However, we need to be able to simulate time for the lending contract, which uses self.blockchain().get_block_timestamp(). Arguably, maybe I shouldn't have implemented this hook now since our priority is the swap contract, but it was quite easy, so whatever.
ACassimiro
approved these changes
Aug 29, 2024
ACassimiro
added a commit
that referenced
this pull request
Aug 30, 2024
* Mx BigUint hooks (#66) * Framework for Mx tests * BigUint operations - new+add * bigIntSub hook * Add bigIntMul hook * Add a bigIntDiv hook * BigInt comparison --------- Co-authored-by: Virgil Serbanuta <Virgil Serbanuta> * Mx blockchain hooks (#67) * MX getCaller hook * Mx get-sc-balance hook * MX getBlockTimestamp hook --------- Co-authored-by: Virgil <25692529+virgil-serbanuta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #66
Closes #48