Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run erc20 #155

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Run erc20 #155

merged 1 commit into from
Oct 18, 2024

Conversation

virgil-serbanuta
Copy link
Member

@virgil-serbanuta virgil-serbanuta commented Oct 11, 2024 •
edited
Loading

No description provided.

@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review October 17, 2024 15:35
yanliu18
yanliu18 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@yanliu18 yanliu18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the helper::require might be seem a little unfriendly. But I am OK to leave it as it is.

@virgil-serbanuta
Copy link
Member Author

LGTM except the helper::require might be seem a little unfriendly. But I am OK to leave it as it is.

Unfortunately, that's what we can do with the current infrastructure. Even if I add a require function in the contract's crate, we would still have to use ::crate_name::require. The other option would be to have a hack in our semantics for this specific function. If you think it would be better, I can implement it.

@virgil-serbanuta virgil-serbanuta merged commit 810fb1c into main Oct 18, 2024
3 checks passed
@virgil-serbanuta virgil-serbanuta deleted the run-erc20 branch October 18, 2024 08:43
@yanliu18
Copy link
Member

Unfortunately, that's what we can do with the current infrastructure. Even if I add a require function in the contract's crate, we would still have to use ::crate_name::require. The other option would be to have a hack in our semantics for this specific function. If you think it would be better, I can implement it.

Let's revisit after the Devcon demo if it is needed.
Thank you, Virgil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanliu18 yanliu18 yanliu18 approved these changes

@ACassimiro ACassimiro Awaiting requested review from ACassimiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgil-serbanuta @yanliu18