Fix single player quick start, add ranking icons to player lists in lobbies #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enumeration is a legacy class used for element iteration and has been superseded by Iterator, which can be looped over using a for-each loop. These are more concise to read and don't pollute variable scopes.
Most of the code was already in place, the regular expression matching packages in the server needed to be adjusted a bit. Also, the game code assumed that everyone starting a game was already in a lobby so I modified the quick start code to join the single player lobby before launching a game.
Instead of constantly polling for changes in the events queue and sleeping, using a BlockingQueue, the server can simply wait until receives any events and then react accordingly. This saves resources and simplifies the server logic.
Registered players have a ranking icon next to their names in lobbies. This also adjusts the default ranking to be 0, instead of 10000 to display the basic ranking icon.
PhilippvK
reviewed
Aug 24, 2024
|
|
||
| while (var3.hasMoreElements()) { | ||
| var3.nextElement().actionPerformed(var2); | ||
| for (ActionListener listener : aVector3280) { |
There was a problem hiding this comment.
Could you deobfuscate aVector3280 to listeners or something else?
There was a problem hiding this comment.
I have a local branch where I convert the codebase from using Vectors everywhere to Lists and that's exactly what I do there: StenAL@7befbe5
I'd prefer to do the deobfuscation as part of the follow-up PR with that commit instead of backporting the changes here if that works for you.
PhilippvK
reviewed
Aug 24, 2024
|
|
||
| while (var3.hasMoreElements()) { | ||
| var3.nextElement().itemStateChanged(var2); | ||
| for (ItemListener listener : aVector3305) { |
PhilippvK
reviewed
Aug 24, 2024
|
|
||
| while (var1.hasMoreElements()) { | ||
| var1.nextElement().realSetState(false); | ||
| for (ColorCheckbox colorCheckbox : aVector1553) { |
PhilippvK
reviewed
Aug 24, 2024
|
|
||
| while (var4.hasMoreElements()) { | ||
| ColorListItem var3 = var4.nextElement(); | ||
| ColorListItemGroup var2 = var3.getGroup(); |
PhilippvK
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Enumerationclass is removed. It is superseded by the more modern approach of using for-each loops which are more concise to read and don't pollute variable scopes.single-player-quick-old.webm
single-player-quick-new.webm