Gpumenu #158
Gpumenu #158
Conversation
Added changeable World Environment
now it is really okay
There was a problem hiding this comment.
I dont know if this is the case here, but for me i noticed this file always changes when i boot up the game even if i haven't made any changes, if that's the case I think it's good practice to not commit these changes in PRs unrelated to the theme file.
There was a problem hiding this comment.
Thank you for your feedback !
In fact, I changed nothing (at least not on purpose) on the theme.
As you may see in other PRs, this theme get updated quite often, so I remove this and try to keep this in mind :)
There was a problem hiding this comment.
Yeah, I can confirm that Cogito_Theme_A.tres gets file changes if you even look at it weird.
Nothing was changed, so there is no need to push.
There was a problem hiding this comment.
I think you deleted the file as a whole instead of removing the changes from the branch
|
Just adding a comment here that I've provided some feedback and thoughts in the Issue thread here: #55 |
- Celling in the Lab made thicker and reduced the spotlight by the desks, moved the sunlight outside the building. - Created a DirectionalLight group to handle the change of non existing DirectionalLight in the Scene - Renamed a few nodes for a better and more similar reading - Added a Headbobble option to the gameplay tab - Commented the glow and sdfgi options plus saves and loads of the cfg
|
So the Headbobble mismatch came from PR#161. |
-swapped out the margin for a grid in the audio tab -added in PR#161 -More chances to apply changes :)
Added changeable World Environment to Lobby and the Lab, took the one from the lobby and put it into scene management for easy reuse.
Added preset graphics options, range from potato to ultra maschine.
The presets do not set the 2D and 3D AA, for now.
So far, I uncommented the directional light on the shadow size, because it all would crash without a directional light in the main menu.
Feel free to edit and to tell me what you think !