-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish perun import and viewdiff #257
Merged
JiriPavela
merged 14 commits into
Perfexionists:devel
from
JiriPavela:feature-polish-import-viewdiff
Sep 25, 2024
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f3e499c
Polish the formatting of exit codes in showdiff
JiriPavela f475414
Rework the profile stats format and parsing
JiriPavela a02bf24
Add support for non-numeric profile stats
JiriPavela 91d769a
Add support for specifying ProfileStat aggregate key
JiriPavela 8996a7e
Add support for profile metadata for imports
JiriPavela 93a6b07
Rework the path handling in perun import
JiriPavela 4fb5e4b
Fix stat generation for showdiff
JiriPavela cf02833
Finish metadata and stats loading and output
JiriPavela 8fa8f43
Refine some names and add missing docstrings
JiriPavela a6367fd
Refactor the imports.py implementation
JiriPavela 226b699
Make diff view info tables collapse both LHS and RHS
JiriPavela 5bf2437
Add detaied stats nested tables to diff view
JiriPavela 2b3fa99
Add more tests for import and diff views
JiriPavela 5f0b4e8
Add perun version and timestamp to diff views
JiriPavela File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? And can you maybe write an example how his is run? That's better readable then nested parenthesized specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parentheses represent optional parts of the import entries. This change was done so that (a) CSV and CLI specification of profiles to import is unified, i.e., it is now possible to specify exactly the same import parameters using both CSV files and CLI, and (b) at least exit code may be specified on CLI alongside the profiles to import. However, the interface is backwards-compatible and simple profile paths, e.g.,
import.stack.gz
may still be specified. An example input containing both exit code and some stats values (corresponding to some specified stats headers defined in option--stats-headers
) is, e.g.,'import.stack.gz,0,18511.379883,367'
.