-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perun import command #237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #237 +/- ##
==========================================
+ Coverage 99.12% 99.17% +0.05%
==========================================
Files 147 149 +2
Lines 10001 10111 +110
==========================================
+ Hits 9913 10028 +115
+ Misses 88 83 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, adding support for importing external profiles seems like a good idea.
Maybe a quick idea for a slight improvement: would it make sense to allow the user to import the profiling configuration (i.e., cmd, workload, warmups, ...) using a single file, similarly to how the machine info is imported? I can see it being a bit mundane having to specify numerous parameters in the future if / when we decide to support more external profiles, e.g., Valgrind.
This is good idea, but I would probably make this more generic and solve it in different PR. For now it is like this after consultation with JH, who was not a fan of the additional file :) |
No description provided.