Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perun import command #237

Merged
merged 15 commits into from
Jul 22, 2024
Merged

Add perun import command #237

merged 15 commits into from
Jul 22, 2024

Conversation

tfiedor
Copy link
Collaborator

@tfiedor tfiedor commented Jul 17, 2024

No description provided.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (2aa98d6) to head (25f323d).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #237      +/-   ##
==========================================
+ Coverage   99.12%   99.17%   +0.05%     
==========================================
  Files         147      149       +2     
  Lines       10001    10111     +110     
==========================================
+ Hits         9913    10028     +115     
+ Misses         88       83       -5     
Flag Coverage Δ
coverage-3.10 99.17% <100.00%> (+0.06%) ⬆️
coverage-3.11 99.17% <100.00%> (+0.05%) ⬆️
coverage-3.12 99.16% <100.00%> (+0.05%) ⬆️
coverage-3.9 99.16% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfiedor tfiedor requested a review from JiriPavela July 18, 2024 20:33
Copy link
Collaborator

@JiriPavela JiriPavela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, adding support for importing external profiles seems like a good idea.

Maybe a quick idea for a slight improvement: would it make sense to allow the user to import the profiling configuration (i.e., cmd, workload, warmups, ...) using a single file, similarly to how the machine info is imported? I can see it being a bit mundane having to specify numerous parameters in the future if / when we decide to support more external profiles, e.g., Valgrind.

perun/cli_groups/import_cli.py Outdated Show resolved Hide resolved
perun/cli_groups/import_cli.py Outdated Show resolved Hide resolved
perun/profile/imports.py Outdated Show resolved Hide resolved
utils/generate_machine_info.sh Outdated Show resolved Hide resolved
@tfiedor
Copy link
Collaborator Author

tfiedor commented Jul 22, 2024

Great, adding support for importing external profiles seems like a good idea.

Maybe a quick idea for a slight improvement: would it make sense to allow the user to import the profiling configuration (i.e., cmd, workload, warmups, ...) using a single file, similarly to how the machine info is imported? I can see it being a bit mundane having to specify numerous parameters in the future if / when we decide to support more external profiles, e.g., Valgrind.

This is good idea, but I would probably make this more generic and solve it in different PR. For now it is like this after consultation with JH, who was not a fan of the additional file :)

@tfiedor tfiedor merged commit c1e1484 into devel Jul 22, 2024
19 checks passed
@tfiedor tfiedor deleted the command-import branch July 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants