Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jinja2 issue with editable build #235

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Fix jinja2 issue with editable build #235

merged 6 commits into from
Jul 17, 2024

Conversation

tfiedor
Copy link
Collaborator

@tfiedor tfiedor commented Jul 17, 2024

No description provided.

@tfiedor tfiedor linked an issue Jul 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (devel@16e9be3). Learn more about missing BASE report.
Report is 9 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff            @@
##             devel     #235   +/-   ##
========================================
  Coverage         ?   99.12%           
========================================
  Files            ?      147           
  Lines            ?    10001           
  Branches         ?        0           
========================================
  Hits             ?     9913           
  Misses           ?       88           
  Partials         ?        0           
Flag Coverage Δ
coverage-3.10 99.12% <100.00%> (?)
coverage-3.11 99.12% <100.00%> (?)
coverage-3.9 99.10% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfiedor tfiedor requested a review from JiriPavela July 17, 2024 08:53
Copy link
Collaborator

@JiriPavela JiriPavela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm wondering whether we should perhaps add at least one tox environment to test editable installs as well, so that we can somewhat reliably discover such issues early.

perun/view_diff/sankey/run.py Outdated Show resolved Hide resolved
@tfiedor
Copy link
Collaborator Author

tfiedor commented Jul 17, 2024

Looks good. I'm wondering whether we should perhaps add at least one tox environment to test editable installs as well, so that we can somewhat reliably discover such issues early.

Good idea, done.

@tfiedor tfiedor merged commit 2aa98d6 into devel Jul 17, 2024
19 checks passed
@tfiedor tfiedor deleted the jinja-fix branch July 17, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jinja2 - PackageLoader unable to find the installation of perun
2 participants