Stand alone delta debugging command #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozartPanda
changed the title
|
Thanks for the PR, we are currently quite swamped with Jirka (we are leading some workshop tomorrow), hopefully we will look at it at the end of the week. |
JiriPavela
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Overall, the code looks good. Please look into the feedback I've provided and try to resolve it.
When writing the type annotations, you can check whether the annotations are correct by running make check, which does type checking using mypy.
Also, consider adding some tests for your new package (see the tests folder in perun) so that we know when something breaks in the future.
MozartPanda
force-pushed
the
deltaDebugging
branch
from
05ef860
to
a926842
Compare
MozartPanda
force-pushed
the
deltaDebugging
branch
from
831bcad
to
fc5f2a7
Compare
JiriPavela
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the implementation of delta debugging for a stand alone cli command.