-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stand alone delta debugging command #213
Conversation
Thanks for the PR, we are currently quite swamped with Jirka (we are leading some workshop tomorrow), hopefully we will look at it at the end of the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code looks good. Please look into the feedback I've provided and try to resolve it.
When writing the type annotations, you can check whether the annotations are correct by running make check
, which does type checking using mypy.
Also, consider adding some tests for your new package (see the tests
folder in perun
) so that we know when something breaks in the future.
05ef860
to
a926842
Compare
831bcad
to
fc5f2a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I think we're ready for a merge. Good job.
This pull request includes the implementation of delta debugging for a stand alone cli command.