Format with black #123
Format with black #123
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #123 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 130 130
Lines 8594 8594
=======================================
Hits 8475 8475
Misses 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Good job, please fix the typing errors first and then I will look into the individual files and see whether we need to custom-format ( |
HarryMichal
force-pushed
the
format-with-black
branch
2 times, most recently
from
32a7a06
to
b200836
Compare
Also, add a note about the tool in the CONTRIBUTING guidelines.
The line length parameter has been set to 100, as this is the line length we have been using throughout the development of Perun.
JiriPavela
force-pushed
the
format-with-black
branch
from
a7c7fbd
to
69e4f1d
Compare
Base black configuration does not format strings that are too long. A `--experimental-string-processing` flag has been used to format them properly.
JiriPavela
force-pushed
the
format-with-black
branch
from
202e746
to
d1bb9a6
Compare
There was a problem hiding this comment.
I polished the PR and I think we are ready for a merge. There might still be some code blocks that were perhaps formatted too aggressively, but we can solve those ad-hoc as we spot them.
Also, there are some Codacy issues that I believe were in the codebase before this PR, but they were likely triggered again by the formatting changes. I would leave fixing those issues for the #133.
| "vcs": ["git"], | ||
| "collect": ["trace", "memory", "time"], | ||
| "postprocess": ["filter", "normalizer", "regression-analysis"], | ||
| "view": [ |
There was a problem hiding this comment.
I don't really like how black formatted this.
Helps with #97.