-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move a helper function to prevent circular dependency #120
Move a helper function to prevent circular dependency #120
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #120 +/- ##
==========================================
- Coverage 98.04% 97.95% -0.10%
==========================================
Files 129 129
Lines 8686 8686
==========================================
- Hits 8516 8508 -8
- Misses 170 178 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
01ca5c1
to
3bc1aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the new typing errors that emerged after a new mypy version has been released. I think we're ready to merge now.
I think the last two commits can be squashed. |
Good idea, I think we could perhaps go even one step further and do squash&merge of the entire PR. What do you think @tfiedor? |
I am not fan of squash, unless the commiter is dirty bastard (i.e., writing commit messages such as EDIT: Also, you will appreciate more granular history once you bugfix some issue introduced in history, needing |
I agree on not squashing the whole PR but the last two commits are related, so I don't see a problem with squashing those two (I regularly amend commits and then force push). But every maintainer has a different taste, so you decide :). |
Since the
sanitize_filepart
function does not rely on anything in theperun.profile
module, it can be safely moved out into a more neutral module.I encountered the following traceback while playing around with Perun.