Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of nitrogen and methane equations #14

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

dlebauer
Copy link
Member

@dlebauer dlebauer commented Jul 25, 2024

This is a very rough draft of equations required to simulate N2O and CH4.

I am not sure that latex + markdown was the best place to start, maybe pencil and paper or whiteboard would be better. But ... here we are! Definitely open to suggestions.

I wanted to follow the original formulation, but it uses T to mean both Temp and Transpiration; D for Day and Dependence function. This draft almost certainly contains inconsistent notation and many equations are placeholders.

Here is a rendered version: https://rpubs.com/dlebauer/sipnet_equations

Since @Alomir will lead implementation, I think the next step will be for him and me to discuss what would be most useful.

@dlebauer dlebauer marked this pull request as draft July 25, 2024 17:53
Copy link
Member Author

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this is divided into "Current SIPNET" and "Proposed Updates". These should be combined into "Model structure" and each subsection "State variables", "Initial Values", etc should be separated into "Current" and "Proposed". This will require integrating original table into parameter lists, rewriting equations from Appendix A.

TODO:

  • Table w/ events, what defines that event: parameters & pools that will change, source of data (working table for brainstorming w/in team & w/ CARB)
  • Annual vs Date Boolean
  • Source of data

Perhaps we don't actually need to rewrite existing equations unless we want to update the notation.

Add list of drivers

  • met
  • irrig
    • set min water content
  • fertilization -
    • increase pool sizes (NH4, NO3, SOC-C, N)
  • tillage
    • increase k for n months
    • alter bulk density?
  • planting
    • add small leaf and roots
  • harvest
    • % removed
    • % that goes to litter

Add equations required to represent agronomic events in the code

Biogeochemical Dynamics

  • N Cycle
  • Methanogenesis,
  • Both require estimation of % soil in anaerobic state

Boundary conditions

  • soil (water holding capacity ... anything else?)

State variables to add

  • soil T
  • litter C
  • litter N
  • Plant Wood and Leaf N: N_W, N_L (Analogous to C_W wood carbon)

Outputs:

  • SOC
  • N2O
  • CH4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants