Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #57 (Search bar not visible) #64

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

eshantri
Copy link
Collaborator

@eshantri eshantri commented Oct 1, 2024

This PR fixes issue #57 .
Issue
Search bar becomes invisible after something is typed into it.

Fix

  1. Minor css fix, the fix disables the overflow on the y-axis, in Documentation view.
  2. Have attached the videos for tests on Chrome and Firefox. In the test, I type in the bar, the search focuses highlighted elements, then we press backspace key which deletes the input, upon scrolling up we observe the search bar is still present.
website_chrome.mp4
Recording.2024-10-01.182636.mp4

@eshantri eshantri self-assigned this Oct 1, 2024
@eshantri eshantri requested a review from dlebauer October 1, 2024 15:00
Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and fixing the issue! Amazing that the fix seems so simple!

@dlebauer
Copy link
Member

dlebauer commented Oct 1, 2024

@eshantri unless we are going to need the code in the future, would it be better to just delete it instead of commenting it out?

@dlebauer dlebauer merged commit b817193 into PecanProject:master Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants