Fix import of libpypctsp

PatrickOHara · Apr 8, 2024 · 340754f · 340754f
1 parent fb73d63
commit 340754f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
-      uses: actions/checkout@v2  
+      uses: actions/checkout@v2
     - name: Create tag artifact
       uses: actions/upload-artifact@v2
       with:

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.29)
+cmake_minimum_required(VERSION 3.27)
 project(pctsp_project)
 
 set(CMAKE_CXX_STANDARD 17)

diff --git a/Dockerfile b/Dockerfile
@@ -19,5 +19,5 @@ RUN git clone https://github.com/rhgrant10/tsplib95.git /app/tsplib95
 COPY . /app/pctsp
 
 # Install package
-RUN pip3 install pybind11
+RUN pip3 install pybind11 ninja
 RUN pip3 install /app/pctsp
diff --git a/pctsp/CMakeLists.txt b/pctsp/CMakeLists.txt
@@ -1,11 +1,9 @@
 add_library(pypctsp SHARED "pypctsp.cpp")
-
-set_target_properties(pypctsp PROPERTIES SUFFIX ${Python_SOABI})
-set_property(TARGET ${TARGET} PROPERTY CXX_STANDARD 17)
+set_target_properties(pypctsp PROPERTIES SUFFIX ".${Python_SOABI}.so" CXX_STANDARD 17)
 
 # setting for Mac OS X
 if ( ${CMAKE_SYSTEM_NAME} MATCHES "Darwin" )
-    set_target_properties( pypctsp PROPERTIES LINK_FLAGS "-undefined dynamic_lookup" )
+	set_target_properties( pypctsp PROPERTIES LINK_FLAGS "-undefined dynamic_lookup" )
 endif()
 
 target_include_directories(pypctsp PUBLIC ${PCTSP_INCLUDE_DIRS})