Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Admin to disable Two-Factor Authentication #16899

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Oct 17, 2024

Fix #13954

Adding a feature to allow user that is able to edit users to also disable their 2FA.

In the process I fixed the following existing issues:

  • Invalid Email confirmation link being send to the emails.
  • When the Registration feature is disabled but the RegistrationSettings.UsersMustValidateEmail is set to true, the Users admin UI will show the "Send verification email" button next to the user.
  • When the user clicks on "Send verification email" it did not work in the past because that action in in EmailConfirmation not Registration controller.

Also, I added "Actions" button next to the user and moved the following buttons into it

  • Unlock
  • Delete
  • Send verification email
  • Disable two-factor authentication << this was added.

@MikeAlhayek MikeAlhayek merged commit 50e9bba into main Oct 17, 2024
13 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/allow-admin-to-disable-2fa branch October 17, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way for admins to disable 2FA for a user
2 participants