Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GraphQL to 8.0.2 #16736

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Upgrade GraphQL to 8.0.2 #16736

wants to merge 15 commits into from

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Sep 16, 2024

Fixes #16826.

@MikeAlhayek
Copy link
Member Author

@hyzx86 you upgraded GraphQL package last time. You may be more familiar with this. Can you please check this out?

@hishamco
Copy link
Member

IMHO we need to stop bumping the packages ourselves like you said before until the Dependabot is fixed

@MikeAlhayek
Copy link
Member Author

IMHO we need to stop bumping the packages ourselves like you said before until the Dependabot is fixed

The Dependabot is fixed. But it can't do breaking changes like this one. These will need to always be done manually.

@hishamco
Copy link
Member

I thought it was straightforward

Anyhow, to try to fix the broken unit tests. @hyzx86 your help appreciated

@hyzx86
Copy link
Contributor

hyzx86 commented Sep 18, 2024

This problem seems to be related to dynamically generated filtering conditions.

Sorry, I'm busy with other projects recently. It's at a critical stage, and I may not have time to deal with this problem for some time.

@hishamco
Copy link
Member

Thanks @hyzx86

@MikeAlhayek can you handle this? Or we might need help from @carlwoodhouse or @mdameer who worked recently on some GraphQL PRs

@MikeAlhayek
Copy link
Member Author

This is going to be a breaking change and should not be part of 2.x. We should wait until 3 before doing this as we have to set ResolvedType instead of Type on all fields (including custom fields in external projects).

@hishamco
Copy link
Member

So, let us defer this PR then

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@hishamco
Copy link
Member

hishamco commented Oct 1, 2024

Let us defer this for now

@MikeAlhayek
Copy link
Member Author

Please ignore and keep this PR open until we are ready to tackle it for 3.0

@Piedone
Copy link
Member

Piedone commented Oct 3, 2024

Created #16826 to track this.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade GraphQL to 8.x.x
4 participants