-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Players #869
base: development
Are you sure you want to change the base?
Players #869
Conversation
jsteltze
commented
Apr 6, 2022
- players.php + players.tpl : search players by their name (only draft)
- find-old.sh : small bash script to search the code base
- main.tpl + sys_main.tpl : by default fold the not so important menus
- viewcache.php : add properties if the user has favorited this cache + his last log id
- viewcache.tpl : some UI changes for the cache metadata / title / coordinates section
Die Player Sachen sehen recht riesig aus. Welche Datei hast Du dafür als Basis genommen? :-) |
Das stimmt, die player-Sachen sind echt unübersichtlich. Ich würde die auch selber nicht in den Wirkbetrieb nehmen. Hab sie nur nicht mehr aus meinem Branch rausoperiert bekommen. Man sieht das Menü allerdings sowieso nur, wenn es in der DB konfiguriert würde. Somit wäre es vorerst verborgen. |
Die players.php ist aber dann öffentlich erreichbar. Daher würde ich die in dem Zustand ungerne mergen. Wenn Du das öffnen/schließen der Menüpunkte noch in ein lokal Storage packst, also der ausgewählte Zustand des Besuchers. Kann das gemerged werden :-) |
Das |
Wo hast Du das find-old.sh gefunden? Ich finde keins O_o. Ja sollte sich verschieben lassen. |
Danke für Eure Anmerkungen. Ja, die |
Ich habe noch ein paar Anpassungen gemacht:
|
Thank you for moving the There is a issue with the toggling menu. See: jsteltze#1 For the new view on the cache header I have some feedback:
Also a merge of the change related to the new icons is needed bevor this can be merged to development. |
@@ -72,6 +72,12 @@ | |||
document.getElementById('convert_waypoints').style.display = 'none'; | |||
} | |||
|
|||
function showalllists() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's messy already. But I would like to stick to one of the already used ways on how to write names. So showAllLists
or show_all_lists
. Maybe we need to agree on a style project wiede :-)
@@ -133,6 +133,18 @@ function flashbutton(bname) | |||
document.getElementsByName(bname)[0].className = "formbutton_active"; | |||
window.setTimeout('resetbutton(\'' + bname + '\')', 350); | |||
} | |||
|
|||
function toggleMenu(divid) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here I would like if we use one way of writing names which is already used.