Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Ownable 2 step #352

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[Draft] Ownable 2 step #352

wants to merge 4 commits into from

Conversation

ggonzalez94
Copy link
Collaborator

Resolves #290

  • Introduce a new Ownable2Step contract
  • Make onlyOwner() internal in Ownable and implement MethodError to be able to use the error in our new contract(we've already seen we will need it for others)

PR Checklist

  • Unit Tests
  • e2e Tests
  • Documentation

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit e00fbc3
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67102da333906000086cf518

@ggonzalez94 ggonzalez94 marked this pull request as draft October 16, 2024 21:18
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.2%. Comparing base (46eabf0) to head (e00fbc3).

Files with missing lines Patch % Lines
contracts/src/access/ownable_two_step.rs 89.1% 17 Missing ⚠️
contracts/src/access/ownable.rs 76.9% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/access/ownable.rs 74.5% <76.9%> (-2.0%) ⬇️
contracts/src/access/ownable_two_step.rs 89.1% <89.1%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Ownable2Step
1 participant