gsim: support gsim based on verilator framework #491
+140
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poemonsense
reviewed
Oct 31, 2024
|
|
||
| #ifdef GSIM | ||
| dut_ptr->step(); | ||
| if (dut_ptr->get_difftest$$uart$$out$$valid()) { |
There was a problem hiding this comment.
Maybe we should improve gsim with better namings? $$ seems strange in the source code. How about proposing changing gsim to be the same as verilator?
There was a problem hiding this comment.
Sure, I will try to propose changing it.
klin02
force-pushed
the
gsim-mk
branch
2 times, most recently
from
2074f16
to
4735d21
Compare
|
|
klin02
force-pushed
the
gsim-mk
branch
2 times, most recently
from
34f4b38
to
2422a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.