-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dbltrp): add support for critical-error #486
Conversation
3f570f9
to
5ce068b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between this and trap?
|
In the future, an option will be introduced to enter debug mode in the event of a |
Make sense. Look good. Maybe we should add comments to explain its relationship with the double trap extension. |
Sure, I have updated the comment to clarify the relationship. |
Thanks. Merged. |
This pr raise critical-error in difftest when XiangShan issues a critical-error signal.
The
critical-error
state is defined in thesmdbltrp
extension. This extension specifies that when thecritical-error
signal is asserted, the CPU should halt execution. This PR implements a method for stopping execution in simulation mode, where difftest halts by triggering anabort
.In the future, an option to enter debug mode rather than directly halting the CPU will be introduced for handling
critical-error
. This incoming change won’t require modifications to the difftest framework; Xiangshan will only need to control it through anvalid
signal.