Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palladium: add scripts #286

Merged
merged 1 commit into from
Feb 8, 2024
Merged

palladium: add scripts #286

merged 1 commit into from
Feb 8, 2024

Conversation

klin02
Copy link
Member

@klin02 klin02 commented Feb 7, 2024

Now we release related palladium scripts and user should set PLDM_HOST for internal information.
We use wildcard for boards occupation in compilerOptions.qel, it can automatically choose approprate boards count. User can also set it manully like {boards 0+1.1+1.2}, which means occupy 1 board and 2 extra domains. It can be estimated by gate count in xe.msg.

poemonsense
poemonsense previously approved these changes Feb 8, 2024
Copy link
Member

@poemonsense poemonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, look good to me. Feel free to merge it.

* $test$plusargs TB_IMPORT
* $value$plusargs TB_IMPORT
* $finish TB_IMPORT
* $random TB_IMPORT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This red mark shown by GitHub means there's no trailing \n (no newline) at the end of this file.

Leave a \n after the last line (adding a blank line in vscode, or just save the file in vim should work).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red mark is not shown in the review window. It will be shown in the "Files changed" tab.

@@ -0,0 +1,6 @@
debug .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still worried about whether we should provide the simulation scripts. Will they change frequently? Are they dependent of the underlying palladium platform?

I'm not familiar with palladium. If the answers are not, I'm good with the changes.

Copy link
Member Author

@klin02 klin02 Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our current usage, the emulation script does not need to be changed and independent of underlying palladium platform version.

Take run.tcl as example:
xc on -zt0 -xt0 -tbrun means Hardware will set X and Z to 0, and has behaviour delay, which means block Hardware until Software func (except Gfifo Declared) called this cycle are done.
run -swap means read memory from file. Which support we load workload by fread.
run starts simulation.

Now we release related palladium scripts and user should set PLDM_HOST
for internal information.
We use wildcard for boards occupation in compilerOptions.qel, it can
automatically choose approprate boards count. User can also set it
manully like {boards 0+1.1+1.2}, which means occupy 1 board and 2 extra
domains. It can be estimated by gate count in xe.msg.
@poemonsense poemonsense merged commit 74613ab into master Feb 8, 2024
5 checks passed
@poemonsense poemonsense deleted the pldm-scripts branch February 8, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants