Skip to content

Commit

Permalink
timing(StoreQueue): deq exception checking not comparing robidx (#3464)
Browse files Browse the repository at this point in the history
  • Loading branch information
Anzooooo authored Sep 2, 2024
1 parent 2e0c78b commit ddab25a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/main/scala/xiangshan/mem/lsqueue/StoreQueue.scala
Original file line number Diff line number Diff line change
Expand Up @@ -949,11 +949,11 @@ class StoreQueue(implicit p: Parameters) extends XSModule
val ptr = rdataPtrExt(i).value
val mmioStall = if(i == 0) mmio(rdataPtrExt(0).value) else (mmio(rdataPtrExt(i).value) || mmio(rdataPtrExt(i-1).value))
val exceptionValid = if(i == 0) hasException(rdataPtrExt(0).value) else {
hasException(rdataPtrExt(i).value) || (hasException(rdataPtrExt(i-1).value) && uop(rdataPtrExt(i).value).robIdx === uop(rdataPtrExt(i-1).value).robIdx)
hasException(rdataPtrExt(i).value) || (hasException(rdataPtrExt(i-1).value))
}
val vecNotAllMask = dataModule.io.rdata(i).mask.orR
// Vector instructions that prevent triggered exceptions from being written to the 'databuffer'.
val vecHasExceptionFlagValid = vecExceptionFlag.valid && isVec(ptr) && vecExceptionFlag.bits.robIdx === uop(ptr).robIdx
val vecHasExceptionFlagValid = vecExceptionFlag.valid && isVec(ptr)
if (i == 0) {
// use dataBuffer write port 0 to writeback missaligned store out
dataBuffer.io.enq(i).valid := Mux(
Expand Down

0 comments on commit ddab25a

Please sign in to comment.