Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PR#601): fix a wrong pattern #620

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(PR#601): fix a wrong pattern #620

merged 2 commits into from
Oct 30, 2024

Conversation

xyyy1420
Copy link
Contributor

#601 brings some functional issues, this pr fix it

Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
Copy link
Contributor Author

xyyy1420 commented Oct 30, 2024

@poemonsense Would you mind testing with this branch? Check the problem has been fixed?

@xyyy1420 xyyy1420 marked this pull request as ready for review October 30, 2024 07:04
Signed-off-by: jiaxiaoyu <xyyy1420@gmail.com>
@xyyy1420
Copy link
Contributor Author

@poemonsense Would you mind testing with this branch? Check the problem has been fixed?

image

already fixed, check it again?

@poemonsense
Copy link
Member

already fixed, check it again?

Try running all tests in the riscv-dv directory? I just copied all cases there

@xyyy1420
Copy link
Contributor Author

already fixed, check it again?

Try running all tests in the riscv-dv directory? I just copied all cases there

ok

@poemonsense
Copy link
Member

already fixed, check it again?

Try running all tests in the riscv-dv directory? I just copied all cases there

ok

Maybe using -C 10000 to limit the simulation cycle.

@xyyy1420
Copy link
Contributor Author

xyyy1420 commented Oct 30, 2024

already fixed, check it again?

Try running all tests in the riscv-dv directory? I just copied all cases there

ok

Maybe using -C 10000 to limit the simulation cycle.

all test cases have passed, logs are placed in /nfs/home/jiaxiaoyu/fix_refactor_nemu/test_logs

@poemonsense
Copy link
Member

all test cases have passed, logs are placed in /nfs/home/jiaxiaoyu/fix_refactor_nemu/test_logs

Thank you very much for the work. Will merge it once CI passes

@poemonsense poemonsense merged commit 7e6edfa into master Oct 30, 2024
7 checks passed
@poemonsense poemonsense deleted the refactor branch October 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants