Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips #253

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Tooltips #253

merged 2 commits into from
Aug 30, 2024

Conversation

Hop311
Copy link
Contributor

@Hop311 Hop311 commented Aug 26, 2024 •
edited
Loading

Adds tooltip support for:

  • buttons, progress bars (just works, must set text manually though including progress bar percentage)
  • labels and icons (mouse filter must be changed from IGNORE to PASS before adding a tooltip, and the node should be reparented if it would block clicks to a sibling button)
  • pie charts (works automatically, with name + percentage for each slice)
  • TODO - line graphs once they're implemented

Various tooltips are implemented as examples, some using placeholder text.

@Hop311 Hop311 changed the base branch from master to gui-text-label August 26, 2024 23:13
@Hop311 Hop311 added the enhancement New feature or request label Aug 26, 2024
@Hop311 Hop311 marked this pull request as ready for review August 28, 2024 22:16
Spartan322
Spartan322 previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, works great on Linux

Base automatically changed from gui-text-label to master August 30, 2024 21:30
@Hop311 Hop311 dismissed Spartan322’s stale review August 30, 2024 21:30

The base branch was changed.

@Hop311 Hop311 merged commit 2e0bc5b into master Aug 30, 2024
18 checks passed
@Hop311 Hop311 deleted the tooltip branch August 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spartan322 Spartan322 Spartan322 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hop311 @Spartan322