Fix Minimap click doing nothing #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
force-pushed
the
fix/map-behavior
branch
from
1423320
to
4a4a018
Compare
Hop311
reviewed
May 17, 2024
There was a problem hiding this comment.
I think it would be better to unset the hovered province when the mouse goes out of the window, rather than leaving the last hovered province set.
Also edge scrolling continues in the direction of the last recorded _mouse_pos_viewport value when the mouse exits the window, better to stop edge scrolling when the mouse is out of the window (but ideally still move if it's over a menu in the window).
Spartan322
force-pushed
the
fix/map-behavior
branch
from
4a4a018
to
fbea6b3
Compare
Spartan322
force-pushed
the
fix/map-behavior
branch
from
fbea6b3
to
944300f
Compare
Hop311
reviewed
May 18, 2024
Add MapView queue_province_hover_update Makes province hover much more reliable Fix edge scrolling continuing when mouse leaves window Add province hover reset when mouse leaves the window Change _edge_move_threshold to 0.025
Spartan322
force-pushed
the
fix/map-behavior
branch
from
944300f
to
67f20db
Compare
Hop311
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MapView queue_province_hover_update
Fix edge scrolling continuing when mouse leaves window
Add province hover reset when mouse leaves the window
Change _edge_move_threshold to 0.025