Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-allocate and use std::move for Godot Arrays and Dictionaries #218

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Pre-allocate and use std::move for Godot Arrays and Dictionaries #218

merged 1 commit into from
Apr 21, 2024

Conversation

Hop311
Copy link
Contributor

@Hop311 Hop311 commented Apr 20, 2024

  • Reduces unnecessary re-allocations and copies by resizing godot::Arrays before filling them and std::move-ing godot::Arrays and godot::Dictionarys.
  • Check return value of resize calls.

@Hop311 Hop311 added the enhancement New feature or request label Apr 20, 2024
@Spartan322
Copy link
Member

Is move even necessary for a CoW collection?

Base automatically changed from update-sim to master April 21, 2024 06:58
@Hop311 Hop311 merged commit 34f1615 into master Apr 21, 2024
18 checks passed
@Hop311 Hop311 deleted the array-dict-tweaks branch April 21, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spartan322 Spartan322 Spartan322 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hop311 @Spartan322