Restrict runtime saves #1178
Open
Restrict runtime saves #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsstephan
force-pushed
the
restrict-runtime-saves
branch
from
81773f5
to
4e54d50
Compare
|
This should work well to prevent host disconnect. We'll review the user experience on this one, but I imagine for now we can do something like this. |
the USB host port uses the flash, as does our config. both cores accessing the flash at the same time is no good and will crash the host port, so the host port core is locked when writing flash for saving the config, but this disables interrupts on the port and may interfere with auth, so this only saves at runtime when it is safe to (when USB host is disabled), with an optional flag to force saving the config, which should only be used in limited circumstances.
it doesn't use the USB host port for anything so this should always be fine
bsstephan
force-pushed
the
restrict-runtime-saves
branch
from
4e54d50
to
93adf70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in #1176, but saving to flash and host USB conflict, with the current code making the flash write safe but disabling interrupts on host USB's core for long enough to cause the connected dongle to disconnect. This makes most of the saves only occur if host USB is disabled (though they are still forced in the webconfig), and add a hotkey to force a save if you know what you're doing.
Resolves #1176