Precomputation of histogram tails #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
reviewed
Apr 21, 2023
| @@ -98,6 +98,18 @@ def quantiles(self, q: List[float]) -> List[int]: | |||
| return result[::-1] | |||
|
|
|||
|
|
|||
| def histogram_precomputed_tails(hist: Histogram): | |||
There was a problem hiding this comment.
compute_percentage_dropped_for_threshold? (and then to update computations)
There was a problem hiding this comment.
ok, but what do you want to return then? Only one value? or two values: accumulated_weight / total_weight and accumulated_count / total_count?
There was a problem hiding this comment.
AFAIU we can return something like
(bin.lower, ratio_data_dropped) (i.e. ratio data dropped with fixed lower).
If needed absolute numbers, we can return total_data
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A histogram has a sequence of bins. In many situations it is useful to be able to have some aggregated statistics given a bin.lower (aka bin id). In this cl we will introduce aggregations over the tail. For example, given bin.lower = k, what is the total sum of counts from bins with bin.lower >= k.
Checklist