Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to clean up global config instances #18457

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Try to clean up global config instances #18457

merged 1 commit into from
Sep 14, 2021

Conversation

tevans78
Copy link
Member

@tevans78 tevans78 commented Sep 6, 2021 •
edited
Loading

Strictly this behaviour isn't quite right but it may be better than the potential memory leak.
fixes #18426

#build

@LibbyBot
Copy link

LibbyBot commented Sep 6, 2021

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3Nt-gA8tEeypWpIfpUrfSg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Sep 6, 2021

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

LibbyBot commented Sep 7, 2021

The build tevans78-18457-20210906-1023
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3Nt-gA8tEeypWpIfpUrfSg
completed successfully!

@tevans78
Copy link
Member Author

tevans78 commented Sep 9, 2021

#build

@LibbyBot
Copy link

LibbyBot commented Sep 9, 2021

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_2DnoEBGMEeypWpIfpUrfSg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build tevans78-18457-20210909-1746
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_2DnoEBGMEeypWpIfpUrfSg
completed successfully!

@tevans78 tevans78 force-pushed the mpConfigCleanup branch 2 times, most recently from 2e9f858 to 0f80c59 Compare September 10, 2021 13:32
@tevans78
Copy link
Member Author

@build

@tevans78
Copy link
Member Author

Well clearly that should not have been @build ... #build

@LibbyBot
Copy link

Could not find a UUID for the personal build request so perhaps it was never submitted.

Target locations of links might be accessible only to IBM employees.

Emily-Jiang
Emily-Jiang approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tevans78
Copy link
Member Author

#build

@LibbyBot
Copy link

Could not find a UUID for the personal build request so perhaps it was never submitted.

Target locations of links might be accessible only to IBM employees.

@tevans78
Copy link
Member Author

#build

@LibbyBot
Copy link

Could not find a UUID for the personal build request so perhaps it was never submitted.

Target locations of links might be accessible only to IBM employees.

@tevans78
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_PnRMwBSTEey6_dRKrYJmeg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build tevans78-18457-20210913-0712
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_PnRMwBSTEey6_dRKrYJmeg
completed successfully!

@tevans78
Copy link
Member Author

#run-libby-bot

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@tevans78 tevans78 merged commit 7bfb3bc into OpenLiberty:integration Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt left review comments

@Emily-Jiang Emily-Jiang Emily-Jiang approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MicroProfile 4.x: OutOfMemoryError: GC overhead limit exceeded when starting/stopping lots of apps
4 participants
@tevans78 @LibbyBot @Azquelt @Emily-Jiang