Add an AppendNoPush
optimization
#2057
Open
+45
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are ~10.5k usages of
Append
in Paradise bytecode. Of these, all but ~160 immediately pop the value thatAppend
pushes to the stack.This adds a simple
AppendNoPush
peephole opt and opcode, with identical behavior except the opcode handler does not push the result to the stack.