Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of "c++20-pmr" c++ language flavor #346

Closed
wants to merge 7 commits into from
Closed

Add support of "c++20-pmr" c++ language flavor #346

wants to merge 7 commits into from

Conversation

serges147
Copy link

Needed for libcyphal project where I'm planning to use it like this:

    if (CMAKE_CXX_STANDARD STREQUAL "14")
        list(APPEND LOCAL_NNVG_CMD_ARGS "--language-standard=cetl++14-17")
    else ()
        list(APPEND LOCAL_NNVG_CMD_ARGS "--language-standard=c++${CMAKE_CXX_STANDARD}-pmr")
    endif ()

@serges147 serges147 self-assigned this Sep 19, 2024
@serges147 serges147 mentioned this pull request Sep 20, 2024
Merged
github-merge-queue bot pushed a commit to OpenCyphal-Garage/libcyphal that referenced this pull request Oct 7, 2024
@serges147
Application layer libcyphal::application::Node and its `HeartbeatPr…
318898e 
…oducer` & `GetInfoProvider` sub-components. (#386)

- Implemented application layer `Node` class.
- Temporary switch to the specific Nunavut commit, where I've made
necessary fixes (see OpenCyphal/nunavut#346)
  - switch to "pmr" flavor of Nunavut c++ code generation
- modify libcyphal to pass now required pmr allocator to ctor-s of
Nunavut generated messages/requests/responses
- Added new application layer example:
"example_2_application_0_node_hb_getinfo_udp" - demonstrates how to make
a simple libcyphal node using application layer `Node` class.
- Addressed some todos
- A bit more docs
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@serges147 serges147 closed this Oct 14, 2024
@serges147 serges147 deleted the sshirokov/3.0.preview_cpp20_pmr branch October 14, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirtytwobits thirtytwobits Awaiting requested review from thirtytwobits

@pavel-kirienko pavel-kirienko Awaiting requested review from pavel-kirienko

Assignees

@serges147 serges147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@serges147