Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Danger zone: Add config in platform settings (#8284) #8741

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Oct 22, 2024

Proposed changes

  • Add platform_protected_sensitive_config in Default.json
  • frontend get config from Settings

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (7d60d33) to head (c9b1a9e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8741      +/-   ##
==========================================
+ Coverage   66.29%   66.30%   +0.01%     
==========================================
  Files         597      597              
  Lines       60958    60959       +1     
  Branches     6262     6264       +2     
==========================================
+ Hits        40412    40420       +8     
+ Misses      20546    20539       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact changed the title [backend/frontend] Add platform_protected_sensitive_config_is_enabled… [backend/frontend] Danger zone: Add config in platform settings (#8284) Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant