Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Attributes can't have same label and different names in schema (#8726) #8738

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[backend] Attributes can't have same label and different names in schema (#8726) #8738

wants to merge 3 commits into from
+194 −33

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Oct 22, 2024 •
edited
Loading

Proposed changes

  • Attributes can't have same label and different names check at attribute registration
  • Rename label of attributes if an other attribute with same label and different name exists
  • Avoid issues like having filters with same label in a list

Related issues

#8726

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Oct 22, 2024
@Archidoit Archidoit self-assigned this Oct 22, 2024
@Archidoit Archidoit linked an issue Oct 22, 2024 that may be closed by this pull request
[Dashboard] Two "name" filter #8726
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] Two "name" filter
1 participant
@Archidoit