Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] replace plyara with yara-python for yara indicator check (#8291) #8731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Oct 22, 2024

Proposed changes

  • replaced no longer maintained plyara library with yara-python library

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec marked this pull request as ready for review October 22, 2024 08:22
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (e44e755) to head (df3d425).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8731   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files         597      597           
  Lines       60949    60949           
  Branches     6262     6261    -1     
=======================================
+ Hits        40410    40412    +2     
+ Misses      20539    20537    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard
Copy link
Member

aHenryJard commented Oct 22, 2024

I see plyara lib at several places in connector, do we need to move them all to yara-python for consistency ?
https://github.com/search?q=org%3AOpenCTI-Platform%20plyara&type=code

@JeremyCloarec
Copy link
Contributor Author

You're right, I'll update them as well

@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCTI failed to validate YARA rules containing "\r" escape sequence in text strings.
3 participants