[backend] Improve id generation for STIX elements #8671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add more standard id generation tests
github-actions
bot
added
the
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8671 +/- ##
==========================================
+ Coverage 66.06% 66.11% +0.05%
==========================================
Files 597 597
Lines 60913 60962 +49
Branches 6206 6221 +15
==========================================
+ Hits 40241 40305 +64
+ Misses 20672 20657 -15 ☔ View full report in Codecov by Sentry. |
| const relationshipLocatedAt = objects.filter((o) => o.relationship_type === 'located-at'); | ||
| expect(relationshipLocatedAt.length) | ||
| .toBe(130); | ||
| .toBe(125); |
There was a problem hiding this comment.
why do we get less relationships in this test ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve id generation for STIX elements
Add more dependencies
Adapt the graphql model
Add relationship and sighting generation
Related PR
OpenCTI-Platform/connectors#2786
OpenCTI-Platform/client-python#748