Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Threat Actor Relationship Types #8341

Conversation

Bonsai8863
Copy link
Contributor

@Bonsai8863 Bonsai8863 commented Sep 13, 2024

Proposed changes

  • Added 'reports-to' and 'supports' relationships between threat actors

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

No UI changes to test in playwright

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.06%. Comparing base (3497f88) to head (c443bb1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8341      +/-   ##
==========================================
+ Coverage   66.05%   66.06%   +0.01%     
==========================================
  Files         597      597              
  Lines       60871    60895      +24     
  Branches     6202     6202              
==========================================
+ Hits        40206    40232      +26     
+ Misses      20665    20663       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bonsai8863 Bonsai8863 force-pushed the threat_actor_additional_relationships branch 2 times, most recently from 0467ef0 to 95fd678 Compare September 17, 2024 12:53
@Bonsai8863 Bonsai8863 force-pushed the threat_actor_additional_relationships branch 3 times, most recently from f67d272 to 42ba802 Compare September 23, 2024 12:32
@SarahBocognano SarahBocognano added the community use to identify PR from community label Sep 24, 2024
@Bonsai8863 Bonsai8863 force-pushed the threat_actor_additional_relationships branch 3 times, most recently from 1adc654 to 600ac0d Compare October 1, 2024 11:41
@SarahBocognano SarahBocognano self-requested a review October 2, 2024 08:46
@SarahBocognano SarahBocognano self-assigned this Oct 2, 2024
@Bonsai8863 Bonsai8863 force-pushed the threat_actor_additional_relationships branch from 600ac0d to 4ce8bd7 Compare October 3, 2024 08:58
@SarahBocognano SarahBocognano force-pushed the threat_actor_additional_relationships branch from 4ce8bd7 to 11925f1 Compare October 14, 2024 13:50
@SarahBocognano SarahBocognano merged commit 5488891 into OpenCTI-Platform:master Oct 14, 2024
5 checks passed
@Bonsai8863 Bonsai8863 deleted the threat_actor_additional_relationships branch October 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants