[frontend] Add page titles to Settings pages and convert to functional components #8160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerboseCat
force-pushed
the
convert_class_components_settings
branch
2 times, most recently
from
10c779e
to
4f88181
Compare
VerboseCat
force-pushed
the
convert_class_components_settings
branch
5 times, most recently
from
8f8479a
to
cda8fe9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8160 +/- ##
==========================================
- Coverage 66.29% 66.28% -0.01%
==========================================
Files 597 597
Lines 60958 60958
Branches 6262 6263 +1
==========================================
- Hits 40412 40406 -6
- Misses 20546 20552 +6 ☔ View full report in Codecov by Sentry. |
VerboseCat
force-pushed
the
convert_class_components_settings
branch
2 times, most recently
from
a16d044
to
14658ad
Compare
VerboseCat
force-pushed
the
convert_class_components_settings
branch
from
14658ad
to
4eea986
Compare
SamuelHassine
force-pushed
the
master
branch
from
f8359b7
to
558e6c1
Compare
VerboseCat
force-pushed
the
convert_class_components_settings
branch
3 times, most recently
from
c3c5ef3
to
79df089
Compare
VerboseCat
force-pushed
the
convert_class_components_settings
branch
from
79df089
to
4166d20
Compare
VerboseCat
force-pushed
the
convert_class_components_settings
branch
2 times, most recently
from
110452d
to
f917015
Compare
VerboseCat
force-pushed
the
convert_class_components_settings
branch
from
e47c21a
to
d8b2642
Compare
Revert WIP conversion of Sectors test commit Fix paginationOptions issue for Groups, KillChainPhases, Roles Fix MarkingDefinitions, update KillChainPhases to reflect master Remove changes established in PR OpenCTI-Platform#7753 Add Malwares.tsx to removed changes Post-rebase cleanup Remove changes from PR 7753 Remove outdated changes to KillChainPhases Fix translations Align GroupLine design with master Fix typing on GroupLines; Remove variant from breadcrumbs
VerboseCat
force-pushed
the
convert_class_components_settings
branch
from
d8b2642
to
7ad134d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is a follow-up to the the PR which introduced custom page titles (#7374). This PR converts several 'Settings' components from classes to functional and adds page titles. These components were not included in the original PR because they were class components and could not use the page title hook.
Impacted Pages
Related issues
Checklist
Further comments
This PR has a known issue, which has also been reported in a comment on (#7753). Every time a page renders, both the the custom page title setting function
useConnectedDocumentModifier.setTitleand the default page title setting functionuseDocumentLangModifierrun and set the title. In some instances, the default page title is set after the custom page title is set. This results in the default page title being displayed. I was unable to find a cause or pattern for which components exhibit this bug.The following components from this PR are impacted: